save memory of extract_lora_ups_down by returning a generator instead… #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of a list extract_lora_ups_down currently returns a list, by returning a generator we can save some memory
Owner
|
Quick question, was this be compatible with, for example, CLIs and so on? |
Author
|
CLI? Command line interface or some other acronym? If you mean command line interface then yes. If not, then please clarify what acronym you mean. Generators are a widely used python structure, you can learn more about them here, https://wiki.python.org/moin/Generators They have the benefit of less memory usage and you can start consuming them while they are being created, so have shorter runtime. |
Owner
|
Can you change this to dev branch? Thanks |
Author
|
okay it is now PR #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extract_lora_ups_down currently returns a list, by returning a generator we can save some memory. With this change I less frequently get an OOM during saves.