Merged
Conversation
Cancelled jobs mean they have started and so should be included in a trace. Without the cancelled step there would appear to be a massive gap in the trace. Skipped steps _should_ be excluded because they performed no work and will be approximately always zero duration. Fixes corentinmusard#56
Author
|
@wojcikstefan Are you able to give me permission to merge this branch? It's telling me I'm blocked |
Member
|
@andrewbarnhart I merged it just now, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is simply a sync with the upstream changes of this fork.
I had to add ts-node to make the tests pass. I have no idea why things work in the upstream but they don't here.