Allow ordering messages by received date ascending #1017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmelos
force-pushed
the
jpmelos-make-messages-ordering-configurable
branch
from
cb9672a to
8340748
Compare
jpmelos
force-pushed
the
jpmelos-make-messages-ordering-configurable
branch
from
8340748 to
af6e27f
Compare
jpmelos
force-pushed
the
jpmelos-make-messages-ordering-configurable
branch
from
af6e27f to
2d104cb
Compare
mrhiggi-close
approved these changes
Aug 22, 2025
| query = query.order_by(desc(Message.received_date)) | ||
| elif order_by == "received_date": | ||
| query = query.order_by(asc(Message.received_date)) | ||
| elif order_by == "-received_date": |
Contributor
There was a problem hiding this comment.
Nit: Personally, I'd go for if not order_by or order_by == "-received_date"
Member
Author
There was a problem hiding this comment.
The reason I did this is to preserve the semantic difference between "the default" and "the choice that happens to behave the same as the default".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow ordering messages by received date ascending. (And leaves room for more configurable options in the future if desired.) This is useful when debugging things related to syncing emails into Close, and you want to see emails in the order they arrived to understand how the code on the Close side was run.