Merged
Conversation
Since my Python 3.12 upgrade, the GitHub `build-push.yml` Action hasn't been succeeding, complaining about an unspecified issue in a `RUN` command within the `backend.containerfile`. The main relevant change was moving from the CentOS Stream 9 base image to CentOS Stream 10. This was convenient, as it comes with Python 3.12 installed whereas CentOS Stream 9 does not... but it also seems the most likely source of the problem. This is an experiment, to back off to the CentOS Stream 9 base image and manually install Python 3.12 from EPEL. Again, all local testing succeeds: but that was true before, as well, so the real test will start when this PR is merged onto `main`.
We can't run `build-and-push` on a PR since we don't have access to the quay secret; but this creates a stripped down copy (without the push steps) to build containers the same way in a pull request. A useful test ... and more importantly this allows me to debug without merging to `main`. (Should have thought of this earlier ...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Since my Python 3.12 upgrade, the GitHub
build-push.ymlAction hasn't been succeeding, complaining about an unspecified issue in aRUNcommand within thebackend.containerfile.I first tried backing off to the original CentOS Stream 9, which didn't solve the problem: but I'm going to leave it. While having Python 3.12 pre-installed on CentOS Stream 10 was convenient, this won't help to upgrade later to 3.13 (which I'd like to do), so leaving the EPEL setup probably makes sense.
The sticking point appears to be the use of the
redhat-actions/buildah-build@v2Action, which behaves differently from a straightforwardpodman buildcommand with the equivalent parameters. Ultimately, the issue seems to stem from differences betweenbuildah bud, which is the actual command used by the action, andpodman build. For simplicity, I've removed the use of the action plugin in favor of a straightforwardpodman build.Related Tickets & Documents
PANDA-1044 fix container build
Checklist before requesting a review
Testing
Tested locally with
./run-container.sh,test.sh, ande2e.sh, all of which build & run containers using the samebackend.containerfile.I added a new GitHub Action workflow to duplicate the
build-push.yamlbuild process without trying to push a container image to Quay (and which therefore doesn't need the secrets): this allows testing the real build on each PR before merging tomain.