Skipping steps not needed for hypershift #529
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vicente Zepeda Mas <[email protected]>
rsevilla87
reviewed
Feb 23, 2023
| deploy_infra | ||
| tune_workload_node apply | ||
|
|
||
| if [[ ! ${HYPERSHIFT} == false ]]; then |
Member
There was a problem hiding this comment.
Can add this variable HYPERSHIFT to the docs?
Member
There was a problem hiding this comment.
Suggested change
| if [[ ! ${HYPERSHIFT} == false ]]; then | |
| if [[ ${HYPERSHIFT} != "true" ]]; then |
rsevilla87
reviewed
Feb 23, 2023
| done | ||
|
|
||
| enable_ingress_operator | ||
| if [[ ! -z "${INGRESS_OPERATOR_IMAGE}" ]]; then |
Member
There was a problem hiding this comment.
Suggested change
| if [[ ! -z "${INGRESS_OPERATOR_IMAGE}" ]]; then | |
| if [[ -n ${INGRESS_OPERATOR_IMAGE} ]]; then |
rsevilla87
reviewed
Feb 23, 2023
| done | ||
|
|
||
| tune_workload_node delete | ||
| if [[ ${HYPERSHIFT} == false ]]; then |
Member
There was a problem hiding this comment.
Suggested change
| if [[ ${HYPERSHIFT} == false ]]; then | |
| if [[ ${HYPERSHIFT} == "false" ]]; then |
rsevilla87
reviewed
Feb 23, 2023
| reschedule_monitoring_stack worker | ||
| configure_ingress_images | ||
|
|
||
| if [[ ! -z "${INGRESS_OPERATOR_IMAGE}" ]] || [[ ! -z "${HAPROXY_IMAGE}" ]]; then |
Member
There was a problem hiding this comment.
Suggested change
| if [[ ! -z "${INGRESS_OPERATOR_IMAGE}" ]] || [[ ! -z "${HAPROXY_IMAGE}" ]]; then | |
| if [[ -n ${INGRESS_OPERATOR_IMAGE} ]] || [[ -n ${HAPROXY_IMAGE} ]]; then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vicente Zepeda Mas [email protected]
Description
Make she change necesary to skip steps that are not required when running in hypershift or ifsome variables are not defined.
Fixes