Skip to content

Conversation

@akrzos
Copy link
Contributor

@akrzos akrzos commented May 14, 2025

…ube_deployment_spec_replicasandkube_replicaset_spec_replicas`

Type of change

  • Bug fix

Description

Both metrics kube_deployment_labels and kube_replicaset_labels are no longer available in OCP prometheus, instead we can get the counts of deployments from kube_deployment_spec_replicas and the counts of ReplicaSets from kube_replicaset_spec_replicas

…ube_deployment_spec_replicas` and `kube_replicaset_spec_replicas`

Signed-off-by: Alex Krzos <[email protected]>
@openshift-ci openshift-ci bot requested review from afcollins and chentex May 14, 2025 20:30
@openshift-ci
Copy link

openshift-ci bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akrzos
Once this PR has been reviewed and has the lgtm label, please assign krishvoor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented May 14, 2025

Hi @akrzos. Thanks for your PR.

I'm waiting for a cloud-bulldozer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant