Skip to content

Conversation

@afcollins
Copy link
Member

Type of change

  • Bug fix

Description

API Performance Dashboard has many panels that use old metrics and some old APF labels that were migrated to a new format.

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.

@afcollins
Copy link
Member Author

Some screenshots to help with any reviews.
Current state on the left, PR changes on the right.

Across all panels, we should see a descending sort on Max values.

Panels in this screen have appropriate data types for the series displayed.
00_api_request-duration-99th

Data types updated, and 'requests dropped rate' query updated.
01_api_request-duration-rate-joined

'long running requets' query updated from an obsolete metric name. 'p&f - requests rejected' panel removed as similar metric doesn't exist now.
02_api_request-status-rate-joined

'p&f - request wait duration' resized for consistency of other panels. 'p&f - request queue length' and others moved to show in the screen with other API Priority & Fairness (APF) metrics.
03_api_response-size-joined

All APF metric labels and variables were still an obsolete camelCase format that was migrated to a snake_case. All panels here show this change.
04_api_apf-request-dispatch-joined

@afcollins
Copy link
Member Author

Also added on two panels, missing label filters to respond to drop downs.

To demonstrate, we can select a particular verb to see the behavior through all the panels:
api_filter-by-verb

And the same can be done on resource now:
api_filter-by-resource

@afcollins afcollins changed the title WIP - Changes to fix #116 Changes to fix #116 Sep 22, 2025
@afcollins afcollins marked this pull request as ready for review September 22, 2025 22:57
Many quality of life Improvements, including:
* Many snake_case labels in API Priority & Fairness panels
* verb and resource filters on more request panels
* Updated obsolete timeseries
* Units and legends updates
* Panels resize and organized
@afcollins afcollins merged commit 3e24721 into cloud-bulldozer:master Sep 25, 2025
2 checks passed
@afcollins afcollins deleted the fixes_116 branch September 25, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix api performance dashboard p&f labels

1 participant