Skip to content

Conversation

@jameshochadel
Copy link
Contributor

Changes proposed in this pull request:

  • pkg is a common directory for organizing public code
  • vendor, when used, deliberately "vendors" third-party code into the repository; when used, it is intended to be checked in
  • go.mod and go.sum are the files necessary for Go Modules, the Go dependency management tool, to work

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None

- pkg is a common directory for organizing public code
- vendor, when used, deliberately "vendors" third-party code into the repository; when used, it is intended to be checked in
- go.mod and go.sum are the files necessary for Go Modules, the Go dependency management tool, to work
@jameshochadel jameshochadel requested a review from a team as a code owner April 7, 2025 20:20
@jameshochadel jameshochadel merged commit c274a74 into main Apr 7, 2025
3 checks passed
@jameshochadel jameshochadel deleted the fix-go-gitignore branch April 7, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants