Skip to content

Comments

add force_ssl configuration to pipeline#405

Merged
cweibel merged 1 commit intomainfrom
force_ssl
Mar 25, 2025
Merged

add force_ssl configuration to pipeline#405
cweibel merged 1 commit intomainfrom
force_ssl

Conversation

@cweibel
Copy link
Contributor

@cweibel cweibel commented Mar 25, 2025

Changes proposed in this pull request:

  • Should expose rds.force_ssl to be configured for each environment from the pipeline, leaving it as the default value for now so it can be overridden as part of an upgrade.
  • The rest of the whitespace changes are a result of running terraform fmt
  • Part of Postgres upgrade 16.8 - aws_broker in development, staging and production https://github.com/cloud-gov/private/issues/2393

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

This should result in a no-op deployment

@cweibel cweibel requested a review from a team as a code owner March 25, 2025 13:18
@cweibel cweibel changed the title add force_ssl add force_ssl configuration to pipeline Mar 25, 2025
@cweibel cweibel added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit b54a311 Mar 25, 2025
6 checks passed
@cweibel cweibel deleted the force_ssl branch March 25, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants