Skip to content

Comments

Add pgcrypto to aws-broker RDS instances#409

Merged
cweibel merged 4 commits intomainfrom
init-db
Apr 2, 2025
Merged

Add pgcrypto to aws-broker RDS instances#409
cweibel merged 4 commits intomainfrom
init-db

Conversation

@cweibel
Copy link
Contributor

@cweibel cweibel commented Apr 2, 2025

Changes proposed in this pull request:

Security considerations

Needed for CIS Benchmark requirements for pgcypto in Nessus scans

@cweibel cweibel requested a review from a team as a code owner April 2, 2025 15:23
@cweibel cweibel changed the title Init db Add pgcrypto to aws-broker RDS instances Apr 2, 2025
# Remove default privileges
psql_adm -d "${db}" -c "REVOKE ALL ON SCHEMA public FROM PUBLIC"

# Special case for uaadb, create totp seed table for use with MFA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need any of this here? I'm very confused by references to Shibboleth here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to keep the script that runs in terraform-provision as close to this as possible to make future upgrades to the base script easier to roll out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to reuse the script, should we put it in cg-scripts and reference it in the pipelines?

It's a little confusing to have these references in this repo script when they're not related to the aws-broker at all

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the if block to keep the script to only be focused on the RDS instances for aws-broker.

)
EOT

# Enforce cloud.gov origin for IdP users by validating that their username
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming none of this is relevant here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal was to keep this and https://github.com/cloud-gov/terraform-provision/blob/main/ci/scripts/create-and-update-db.sh as close as possible, the only difference now are lines 9&10.

I can pull the entire if block if that is desired, it is, strictly speaking, not required for this RDS instance

@cweibel cweibel added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit e3850bf Apr 2, 2025
4 checks passed
@cweibel cweibel deleted the init-db branch April 2, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants