Skip to content

Fix RDS failures#452

Merged
markdboyd merged 47 commits intomainfrom
fix-rds-failures
Oct 15, 2025
Merged

Fix RDS failures#452
markdboyd merged 47 commits intomainfrom
fix-rds-failures

Conversation

@markdboyd
Copy link
Contributor

@markdboyd markdboyd commented Oct 14, 2025

Changes proposed in this pull request:

  • Fix failures when creating/updating RDS instances by supplying missing plan input. The changes in Upgrade RDS package to SDK v2 #447 inadvertently removed some input that is necessary to specify when creating/modifying instances
  • Address linting issues
  • Remove unused code
  • Update all logging to use real loggers
  • Update test fixtures to match refactored code

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None. Just bug fixes and minor code refactoring

@markdboyd markdboyd marked this pull request as ready for review October 15, 2025 13:38
@markdboyd markdboyd requested a review from a team as a code owner October 15, 2025 13:38
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@markdboyd markdboyd added this pull request to the merge queue Oct 15, 2025
Merged via the queue into main with commit 67ddf97 Oct 15, 2025
5 checks passed
@markdboyd markdboyd deleted the fix-rds-failures branch October 15, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants