Skip to content

Handle 404 on RDS deletion #453

Merged
markdboyd merged 1 commit intomainfrom
fix-db-deletion
Oct 15, 2025
Merged

Handle 404 on RDS deletion #453
markdboyd merged 1 commit intomainfrom
fix-db-deletion

Conversation

@markdboyd
Copy link
Contributor

Changes proposed in this pull request:

  • add logic to return successfully on deletion if database instance was already deleted

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, just making deletion idempotent

@markdboyd markdboyd requested a review from a team as a code owner October 15, 2025 20:05
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@markdboyd markdboyd added this pull request to the merge queue Oct 15, 2025
Merged via the queue into main with commit 4799b38 Oct 15, 2025
5 checks passed
@markdboyd markdboyd deleted the fix-db-deletion branch October 15, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants