Skip to content

Fixes for RDS modify behavior#456

Merged
markdboyd merged 11 commits intomainfrom
fix-rds-modify
Nov 7, 2025
Merged

Fixes for RDS modify behavior#456
markdboyd merged 11 commits intomainfrom
fix-rds-modify

Conversation

@markdboyd
Copy link
Contributor

Changes proposed in this pull request:

  • Ensure that modifications to RDS instance record are only saved if all of the modifications were successful
  • Scale the number of retries in proportion to the database storage size when waiting for a database to become available after creation/modification

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

No changes to security configuration or behavior

@markdboyd markdboyd requested a review from a team as a code owner November 7, 2025 20:29
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@markdboyd markdboyd added this pull request to the merge queue Nov 7, 2025
Merged via the queue into main with commit 0ed2fd6 Nov 7, 2025
5 checks passed
@markdboyd markdboyd deleted the fix-rds-modify branch November 7, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants