Skip to content

Fix concurrency issue#459

Merged
markdboyd merged 12 commits intomainfrom
fix-concurrency-issue
Dec 4, 2025
Merged

Fix concurrency issue#459
markdboyd merged 12 commits intomainfrom
fix-concurrency-issue

Conversation

@markdboyd
Copy link
Contributor

Changes proposed in this pull request:

  • Fix concurrency issue with multiple goroutines writing to RDSInstance.Tags by using a sync.Map for that property
  • Fix awsiam package tests
  • Fix formatting issues

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None of the changes have any security impact

@markdboyd markdboyd requested a review from a team as a code owner December 4, 2025 19:42
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markdboyd markdboyd added this pull request to the merge queue Dec 4, 2025
Merged via the queue into main with commit 914c59c Dec 4, 2025
5 checks passed
@markdboyd markdboyd deleted the fix-concurrency-issue branch December 4, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants