Skip to content

Fixes #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markdboyd merged 2 commits into from
Jul 3, 2025
Merged

Fixes #986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
293a6ab
remove on_success slack notifications
markdboyd Jul 3, 2025
ba108bf
limit permissions for security considerations workflow
markdboyd Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/security-considerations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: Security Considerations

permissions:
pull-requests: read

on:
pull_request:
types: [opened, edited, reopened]
Expand Down
109 changes: 0 additions & 109 deletions ci/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,16 +155,6 @@ jobs:
DISABLED_FEATURE_FLAGS: |
user_org_creation
hide_marketplace_from_unauthenticated_users

on_success:
put: slack
params:
text: |
:white_check_mark: Successfully deployed CF on development
<$ATC_EXTERNAL_URL/teams/$BUILD_TEAM_NAME/pipelines/$BUILD_PIPELINE_NAME/jobs/$BUILD_JOB_NAME/builds/$BUILD_NAME|View build details>
channel: "#cg-platform-news"
username: ((slack-username))
icon_url: ((slack-icon-url))
on_failure:
put: slack
params:
Expand Down Expand Up @@ -490,15 +480,6 @@ jobs:
- -euxc
- |
bosh run-errand smoke-tests
on_success:
put: slack
params:
text: |
:white_check_mark: Smoke Tests for CF on development PASSED
<$ATC_EXTERNAL_URL/teams/$BUILD_TEAM_NAME/pipelines/$BUILD_PIPELINE_NAME/jobs/$BUILD_JOB_NAME/builds/$BUILD_NAME|View build details>
channel: "#cg-platform-news"
username: ((slack-username))
icon_url: ((slack-icon-url))
on_failure:
put: slack
params:
Expand Down Expand Up @@ -548,15 +529,6 @@ jobs:
<<: *test-space-egress-development-clean-tasks
on_success:
<<: *test-space-egress-development-clean-tasks
on_success:
put: slack
params:
text: |
:white_check_mark: Tests for space egress for CF on development PASSED
<$ATC_EXTERNAL_URL/teams/$BUILD_TEAM_NAME/pipelines/$BUILD_PIPELINE_NAME/jobs/$BUILD_JOB_NAME/builds/$BUILD_NAME|View build details>
channel: "#cg-platform-news"
username: ((slack-username))
icon_url: ((slack-icon-url))
on_failure:
put: slack
params:
Expand Down Expand Up @@ -606,15 +578,6 @@ jobs:
<<: *test-headers-development-clean-tasks
on_success:
<<: *test-headers-development-clean-tasks
on_success:
put: slack
params:
text: |
:white_check_mark: Tests for headers for CF on development PASSED
<$ATC_EXTERNAL_URL/teams/$BUILD_TEAM_NAME/pipelines/$BUILD_PIPELINE_NAME/jobs/$BUILD_JOB_NAME/builds/$BUILD_NAME|View build details>
channel: "#cg-platform-news"
username: ((slack-username))
icon_url: ((slack-icon-url))
on_failure:
put: slack
params:
Expand Down Expand Up @@ -765,15 +728,6 @@ jobs:
AWS_ACCESS_KEY_ID: ((staging-route53-aws-access-key))
AWS_SECRET_ACCESS_KEY: ((staging-route53-secret-access-key))

on_success:
put: slack
params:
text: |
:white_check_mark: Successfully deployed CF on staging
<$ATC_EXTERNAL_URL/teams/$BUILD_TEAM_NAME/pipelines/$BUILD_PIPELINE_NAME/jobs/$BUILD_JOB_NAME/builds/$BUILD_NAME|View build details>
channel: "#cg-platform-news"
username: ((slack-username))
icon_url: ((slack-icon-url))
on_failure:
put: slack
params:
Expand Down Expand Up @@ -1012,15 +966,6 @@ jobs:
BOSH_ERRAND: ((cf.staging.smoke-tests))
BOSH_CA_CERT: common/master-bosh.crt
config: *smoke-tests-errand
on_success:
put: slack
params:
text: |
:white_check_mark: Smoke Tests for CF on staging PASSED
<$ATC_EXTERNAL_URL/teams/$BUILD_TEAM_NAME/pipelines/$BUILD_PIPELINE_NAME/jobs/$BUILD_JOB_NAME/builds/$BUILD_NAME|View build details>
channel: "#cg-platform-news"
username: ((slack-username))
icon_url: ((slack-icon-url))
on_failure:
put: slack
params:
Expand Down Expand Up @@ -1103,15 +1048,6 @@ jobs:
params:
FLAKE_ATTEMPTS: 3
SKIP_REGEXP: routing.API|allows\spreviously-blocked\sip|Adding\sa\swildcard\sroute\sto\sa\sdomain|forwards\sapp\smessages\sto\sregistered\ssyslog\sdrains|uses\sa\sbuildpack\sfrom\sa\sgit\surl|when\sapp\shas\smultiple\sports\smapped
on_success:
put: slack
params:
text: |
:white_check_mark: Acceptance Tests for CF on staging PASSED
<$ATC_EXTERNAL_URL/teams/$BUILD_TEAM_NAME/pipelines/$BUILD_PIPELINE_NAME/jobs/$BUILD_JOB_NAME/builds/$BUILD_NAME|View build details>
channel: "#cg-platform-news"
username: ((slack-username))
icon_url: ((slack-icon-url))
on_failure:
put: slack
params:
Expand Down Expand Up @@ -1169,15 +1105,6 @@ jobs:
<<: *test-space-egress-staging-clean-tasks
on_success:
<<: *test-space-egress-staging-clean-tasks
on_success:
put: slack
params:
text: |
:white_check_mark: Tests for space egress for CF on staging PASSED
<$ATC_EXTERNAL_URL/teams/$BUILD_TEAM_NAME/pipelines/$BUILD_PIPELINE_NAME/jobs/$BUILD_JOB_NAME/builds/$BUILD_NAME|View build details>
channel: "#cg-platform-news"
username: ((slack-username))
icon_url: ((slack-icon-url))
on_failure:
put: slack
params:
Expand Down Expand Up @@ -1288,15 +1215,6 @@ jobs:
vars_files:
- cf-manifests/bosh/varsfiles/production.yml
- terraform-secrets/terraform.yml
on_success:
put: slack
params:
text: |
:white_check_mark: CF Production plan ready for review
<$ATC_EXTERNAL_URL/teams/$BUILD_TEAM_NAME/pipelines/$BUILD_PIPELINE_NAME/jobs/$BUILD_JOB_NAME/builds/$BUILD_NAME|View build details>
channel: "#cg-platform"
username: ((slack-username))
icon_url: ((slack-icon-url))
on_failure:
put: slack
params:
Expand Down Expand Up @@ -1377,15 +1295,6 @@ jobs:
user_org_creation
hide_marketplace_from_unauthenticated_users

on_success:
put: slack
params:
text: |
:white_check_mark: Successfully deployed CF on prod
<$ATC_EXTERNAL_URL/teams/$BUILD_TEAM_NAME/pipelines/$BUILD_PIPELINE_NAME/jobs/$BUILD_JOB_NAME/builds/$BUILD_NAME|View build details>
channel: "#cg-platform-news"
username: ((slack-username))
icon_url: ((slack-icon-url))
on_failure:
put: slack
params:
Expand Down Expand Up @@ -1578,15 +1487,6 @@ jobs:
BOSH_ERRAND: ((cf.production.smoke-tests))
BOSH_CA_CERT: common/master-bosh.crt
config: *smoke-tests-errand
on_success:
put: slack
params:
text: |
:white_check_mark: Smoke Tests for CF on prod PASSED
<$ATC_EXTERNAL_URL/teams/$BUILD_TEAM_NAME/pipelines/$BUILD_PIPELINE_NAME/jobs/$BUILD_JOB_NAME/builds/$BUILD_NAME|View build details>
channel: "#cg-platform-news"
username: ((slack-username))
icon_url: ((slack-icon-url))
on_failure:
put: slack
params:
Expand Down Expand Up @@ -1631,15 +1531,6 @@ jobs:
<<: *test-space-egress-production-clean-tasks
on_success:
<<: *test-space-egress-production-clean-tasks
on_success:
put: slack
params:
text: |
:white_check_mark: Tests for space egress for CF on production PASSED
<$ATC_EXTERNAL_URL/teams/$BUILD_TEAM_NAME/pipelines/$BUILD_PIPELINE_NAME/jobs/$BUILD_JOB_NAME/builds/$BUILD_NAME|View build details>
channel: "#cg-platform-news"
username: ((slack-username))
icon_url: ((slack-icon-url))
on_failure:
put: slack
params:
Expand Down