Skip to content

feat: create user roles and permissions page #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
apburnes merged 1 commit into from
Dec 29, 2025
Merged

feat: create user roles and permissions page #222

apburnes merged 1 commit into from
Dec 29, 2025

Conversation

@kevinsmaster5
Copy link
Contributor

@kevinsmaster5 kevinsmaster5 commented Dec 22, 2025 •
edited
Loading

Closes #155

Changes proposed in this pull request:

  • Adds a new page for Sites Roles and Permissions to provide documentation on user management
  • Adds a card under User Management in the dashboard
  • Includes a new description component for the Users collection page so a link can be added that points to the new page.
  • New page utilizes Accordion and In-page navigation elements. Added client-side code to power those as well as previously not forwarded SCSS
  • Provides a workaround for problematic Breadcrumbs behavior

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

There are no security concerns

@kevinsmaster5 kevinsmaster5 marked this pull request as ready for review December 22, 2025 19:06
@kevinsmaster5 kevinsmaster5 requested a review from a team as a code owner December 22, 2025 19:06
@kevinsmaster5 kevinsmaster5 force-pushed the feat-create-user-roles-permission-page branch from f0a8c5b to 0b5f872 Compare December 22, 2025 19:07
apburnes
apburnes reviewed Dec 22, 2025
View reviewed changes
Copy link
Contributor

@apburnes apburnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and adds good context for site managers. The main content updates need to be around the Bot role. A bot has read only access on a per site basis. I tried to flag all the instances the bot role goes beyond read only.

Also, the page renders without being logged into the dashboard. Let's update that to be behind authentication.

src/components/UserRolesAndPermissions/index.tsx Outdated
Capabilities
</h4>
<ul className="margin-top-1">
<li>Publish and update content programmatically.</li>
Copy link
Contributor

@apburnes apburnes Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bot role has read only access. It cannot update or delete content

src/components/UserRolesAndPermissions/index.tsx Outdated
</h4>
<ul className="margin-top-1">
<li>Publish and update content programmatically.</li>
<li>Run automated jobs or deploy pipelines.</li>
Copy link
Contributor

@apburnes apburnes Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run automated jobs or publish the production site

src/components/UserRolesAndPermissions/index.tsx Outdated
<td><Check /></td>
<td><Check /></td>
<td><Check /></td>
<td>Users and Bots can create content;<br/>
Copy link
Contributor

@apburnes apburnes Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<td>Users and Bots can create content;<br/>
<td>Users can create content;<br/>

src/components/UserRolesAndPermissions/index.tsx Outdated
<td><Check /></td>
<td><Check /></td>
<td><Check /></td>
<td>Bots and Managers can update<br/>published content; Users only drafts</td>
Copy link
Contributor

@apburnes apburnes Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managers can update <br/>published content; Users only update content drafts

src/components/UserRolesAndPermissions/index.tsx Outdated
<td><X /></td>
<td><Check /></td>
<td><Check /></td>
<td>Bot deletion limited to automation routines</td>
Copy link
Contributor

@apburnes apburnes Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managers can delete content

src/components/UserRolesAndPermissions/index.tsx Outdated
<td>Delete content</td>
<td><X /></td>
<td><Check /></td>
<td><Check /></td>
Copy link
Contributor

@apburnes apburnes Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bots can't delete

Suggested change
<td><Check /></td>
<td><X /></td>

src/components/UserRolesAndPermissions/index.tsx Outdated
<td>Create or modify content via API</td>
<td><X /></td>
<td><X /></td>
<td><Check /></td>
Copy link
Contributor

@apburnes apburnes Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<td><Check /></td>
<td><X /></td>

src/components/UserRolesAndPermissions/index.tsx Outdated
<td>Trigger CI/CD workflows</td>
<td><X /></td>
<td><X /></td>
<td><Check /></td>
Copy link
Contributor

@apburnes apburnes Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<td><Check /></td>
<td><X /></td>

src/components/UserRolesAndPermissions/index.tsx Outdated
<td>Run scheduled publish tasks</td>
<td><X /></td>
<td><X /></td>
<td><Check /></td>
Copy link
Contributor

@apburnes apburnes Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<td><Check /></td>
<td><X /></td>

src/components/UserRolesAndPermissions/index.tsx Outdated
<td>bot</td>
<td>api</td>
<td>access</td>
<td><Check /></td>
Copy link
Contributor

@apburnes apburnes Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<td><Check /></td>
<td><X /></td>

apburnes
apburnes approved these changes Dec 29, 2025
View reviewed changes
Copy link
Contributor

@apburnes apburnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! This looks good to go.

@kevinsmaster5
feat: create user roles and permissions page
89b7cb9 
chore: enable breadcrumb workaround and title meta

fix: remove unneeded whitepace rule, add missing table text

fix: revise slug to sites roles and permissions page

feat: add Roles and Permissions to User collection description

fix: accomodate grid-col for mobile

fix: unescaped apostrophe

fix: gate the page to logged in users, correct mainly bot-oriented table info
@kevinsmaster5 kevinsmaster5 force-pushed the feat-create-user-roles-permission-page branch from e694b54 to 89b7cb9 Compare December 29, 2025 14:56
@kevinsmaster5
Copy link
Contributor Author

kevinsmaster5 commented Dec 29, 2025

Thanks for the update! This looks good to go.

Squashed the commits 👍

@apburnes apburnes merged commit 44408a0 into main Dec 29, 2025
6 checks passed
@apburnes apburnes deleted the feat-create-user-roles-permission-page branch December 29, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apburnes apburnes apburnes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create user roles and permissions page

3 participants

@kevinsmaster5 @apburnes