Conversation
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
Contributor
|
🤖 Hey ! A preview of the application is available at : https://console-pr-2042.dso.cpin-hp.numerique-interieur.fr Please be patient, deployment may take a few minutes. |
shikanime
force-pushed
the
pr2042
branch
3 times, most recently
from
42129f0 to
ffd1c21
Compare
shikanime
force-pushed
the
pr2042
branch
4 times, most recently
from
77dfdf6 to
e2750af
Compare
shikanime
force-pushed
the
pr2042
branch
5 times, most recently
from
b38f5d1 to
958facd
Compare
StephaneTrebel
requested changes
Mar 30, 2026
Collaborator
StephaneTrebel
left a comment
StephaneTrebel
left a comment
There was a problem hiding this comment.
C'est un bon début, mais outre mes remarques, ça marque d'une doc qui parle de ces changements, de l'implication de system:* dans le système plus général des permissions 😉
...sma/migrations/20260330122500_migrate_project_system_roles_type_system_managed/migration.sql
Outdated
Show resolved
Hide resolved
shikanime
force-pushed
the
pr2042
branch
2 times, most recently
from
f904b13 to
b225304
Compare
shikanime
force-pushed
the
pr2042
branch
3 times, most recently
from
cf3b828 to
c1312ce
Compare
shikanime
force-pushed
the
pr2042
branch
7 times, most recently
from
56f1640 to
f89b55b
Compare
If the usable bubbles up, such as using cpin as an identity provider at the application level, we may re-add the OIDC group and type configuration in the client explicitly. But for the moment and the user experience we decided to hide those two fields. Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
shikanime
force-pushed
the
pr2039
branch
16 times, most recently
from
a26337f to
9bd0e70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the usable bubbles up, such as using cpin as an identity provider at the application level, we may re-add the OIDC group and type configuration in the client explicitly.
But for the moment and the user experience we decided to hide those two fields.
Signed-off-by: William Phetsinorath william.phetsinorath-open@interieur.gouv.fr
Stack created with Sapling. Best reviewed with ReviewStack.