refactor: ♻️ utilization of Helm Chart for CNPG#492
Merged
Falltrades merged 1 commit intodevelopfrom Apr 3, 2025
Merged
Conversation
0ae244d to
2518ac4
Compare
iliesmrf
reviewed
Apr 1, 2025
7dd8dd5 to
2e3021e
Compare
cmon33
approved these changes
Apr 3, 2025
mathieulaude
reviewed
Apr 3, 2025
mathieulaude
reviewed
Apr 3, 2025
2e3021e to
723f346
Compare
mathieulaude
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
Issues numéro: #490
Quel est le comportement actuel ?
As part of the refactoring work on the Socle deployment in GitOps mode, some CNPG objects are still created in the post-install: https://github.com/cloud-pi-native/socle/blob/develop/roles/gitops/post-install/keycloak/tasks/main.yml#L34-L42.
Because we will encounter this for services using CNPG cluster (Sonarqube, Harbor, Gitlab...), we have to refactor the code by using the following charts: https://github.com/cloud-pi-native/helm-charts/tree/main/charts/dso-cnpg.
Quel est le nouveau comportement ?
Cette PR introduit-elle un breaking change ?
Should not.
Autres informations
We need to merge the following related PR first : cloud-pi-native/helm-charts#121, then change the chart version accordingly.