Merged
Conversation
git-subtree-dir: plugins/experimentation git-subtree-split: 0356a223f70ad6f6a4291d50757221926d12872e
Enable experimentation support: update ESLint ignores to include plugins/, add a sidekick plugin config (tools/sidekick/config.json) and a small sidekick script (scripts/sidekick.js) to toggle the external DA experiment module. Add getAllMetadata helper (scripts/shared.js) to collect scoped metadata, introduce AUDIENCES and an experimentation context in scripts/scripts.js, and dynamically load the plugin's eager/lazy entry points when experimentation metadata or sidekick is present. Also wire sidekick import/sidekick-ready handling and adjust DA preview/experiment import logic.
Replace textContent with innerHTML for various UI elements in plugins/experimentation/src/preview.js so labels and action link labels can contain HTML markup. Affected functions: createButton, createPopupItem, createPopupDialog, and createToggleButton. Also minor whitespace cleanups around link/button creation.
|
kunwarsaluja
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #69
Test URLs: