Skip to content

Ue support #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunwarsaluja merged 2 commits into from
Mar 13, 2026
Merged

Ue support #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97f41ba
cards with a link UE fix
ravuthu Mar 13, 2026
d8d6806
Merge branch 'main' of https://github.com/cloudadoption/diyfire into …
ravuthu Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 23 additions & 9 deletions blocks/cards/cards.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
getAuthoredLinks,
normalizePath,
resolveArticlesFromIndex,
isUE,
} from '../../scripts/shared.js';

function buildLinksCard(article) {
Expand Down Expand Up @@ -132,15 +133,28 @@ function decorateDefault(block) {

const linkEl = li.querySelector('.cards-card-image a[href]') || li.querySelector('.cards-card-body a[href]');
if (linkEl) {
const wrapper = createTag('a', {
href: linkEl.getAttribute('href'),
title: linkEl.getAttribute('title')?.trim() || undefined,
class: 'cards-card-link',
});
while (li.firstChild) wrapper.append(li.firstChild);
li.append(wrapper);
linkEl.replaceWith(...linkEl.childNodes);
li.querySelectorAll('.cards-card-body a[href]').forEach((a) => a.replaceWith(...a.childNodes));
if (isUE) {
// In UE: use a <div> wrapper so the authored <a> (with its href) is preserved
const wrapper = createTag('div', { class: 'cards-card-link' });
while (li.firstChild) wrapper.append(li.firstChild);
li.append(wrapper);
//Remove the button class from the link and button-container class from the parent
const parent = linkEl.parentElement;
if (parent) {
parent.classList.remove('button-container');
}
linkEl.classList.remove('button');
} else {
const wrapper = createTag('a', {
href: linkEl.getAttribute('href'),
title: linkEl.getAttribute('title')?.trim() || undefined,
class: 'cards-card-link',
});
while (li.firstChild) wrapper.append(li.firstChild);
li.append(wrapper);
linkEl.replaceWith(...linkEl.childNodes);
li.querySelectorAll('.cards-card-body a[href]').forEach((a) => a.replaceWith(...a.childNodes));
}
}

ul.append(li);
Expand Down