Conversation
- Replace placeholder block-list and block-details with real implementations - Import and use actual block collection data from main branch - Block-details now fetches real JS, CSS, and HTML from AEM Block Collection - Update documentation to reflect 8 fully functional tools (up from 6) - Maintain consistent architecture between local and Workers versions
shsteimer
reviewed
Sep 9, 2025
shsteimer
reviewed
Sep 9, 2025
| "lint": "eslint src/", | ||
| "lint:fix": "eslint src/ --fix" | ||
| "lint:fix": "eslint src/ --fix", | ||
| "build": "echo 'No build step required for Cloudflare Workers'", |
Collaborator
There was a problem hiding this comment.
if it does nothing, then why define it at all?
shsteimer
reviewed
Sep 9, 2025
Comment on lines
+46
to
+50
| "env": { | ||
| "DA_ADMIN_API_TOKEN": "your_api_token_here", | ||
| "HELIX_ADMIN_API_TOKEN": "your_api_token_here", | ||
| "RUM_DOMAIN_KEY": "your_rum_domain_key" | ||
| } |
Collaborator
There was a problem hiding this comment.
I assume the env vars don't work with remote servers? in which case we should remove from docs?
Collaborator
Author
There was a problem hiding this comment.
you can still set them within whatever UI you are using - incl the chatbot.
- Delete test/examples/ directory containing unused example code - These were not actual tests and weren't used in CI/CD or package scripts - Clean up codebase by removing unnecessary files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.