Skip to content

Allow to upgrade from lavinmq shared to dedicated instance #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
oskgu360 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Allow to upgrade from lavinmq shared to dedicated instance #453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions cloudamqp/resource_cloudamqp_instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,19 @@ func resourceInstance() *schema.Resource {
},
CustomizeDiff: customdiff.All(
customdiff.ForceNewIfChange("plan", func(ctx context.Context, old, new, meta any) bool {
// Recreate instance if changing plan type (from dedicated to shared or vice versa)
// Going between RabbitMQ shared and dedicated plans requires resource replacement
oldPlanType := isSharedPlan(old.(string))
newPlanType := isSharedPlan(new.(string))
return !(oldPlanType == newPlanType)

isOldLavinmqSharedPlan := isLavinmqSharedPlan(old.(string))
isNewSharedPlan := isSharedPlan(new.(string))

// We allow moving Lavin Shared to Lavin dedicated, but not reverse
if isOldLavinmqSharedPlan && !isNewSharedPlan {
return false
} else {
return !(oldPlanType == newPlanType)
}
}),
customdiff.ValidateChange("plan", func(ctx context.Context, old, new, meta any) error {
if old == new {
Expand Down Expand Up @@ -347,6 +356,16 @@ func isSharedPlan(plan string) bool {
return false
}

func isLavinmqSharedPlan(plan string) bool {
switch plan {
case
"lemming",
"ermine":
return true
}
return false
}

func isLegacyPlan(plan string) bool {
switch plan {
case
Expand Down