feat: add secure boot option to instance#55
Merged
gabriel-samfira merged 3 commits intocloudbase:mainfrom Dec 22, 2025
Merged
Conversation
gabriel-samfira
requested changes
Dec 17, 2025
Member
gabriel-samfira
left a comment
gabriel-samfira
left a comment
There was a problem hiding this comment.
This is great! Just one small comment, but other wise, this is good to go.
internal/spec/spec.go
Outdated
| r.DisableUpdates = *extraSpecs.DisableUpdates | ||
| } | ||
| if extraSpecs.EnableSecureBoot { | ||
| r.EnableSecureBoot = *extraSpecs.EnableSecureBoot |
Member
There was a problem hiding this comment.
This will probably fail to build, as extraSpecs.EnableSecureBoot is not a pointer anymore. For these 3 values, you can just set the RunnerSpec directly. Like so:
r.EnableSecureBoot = extraSpecs.EnableSecureBoot
r.EnableVTPM = extraSpecs.EnableVTPM
r.EnableIntegrityMonitoring = extraSpecs.EnableIntegrityMonitoring
Contributor
Author
There was a problem hiding this comment.
Aaah my bad, completely forgot to change the tests. That's fixed, thank you!
| if extraSpecs.DisableUpdates != nil { | ||
| r.DisableUpdates = *extraSpecs.DisableUpdates | ||
| } | ||
| if extraSpecs.EnableSecureBoot { |
Member
There was a problem hiding this comment.
Just a nit (functionally it's the same), for bool values, you can skip the if statement. The result is the same:
- default value for a
boolisfalse - The
ifin this case only sets theRunnerSpecvalue if the extra spec istrue - The same effect can be achieved if you simply do a blind assignment.
This is all for future reference. Saves lines of code and simplifies code paths.
gabriel-samfira
approved these changes
Dec 22, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day!
I'm in the need of creating runners with secure boot. I saw that this feature was missing so here's my attempt at the implementation.
I've built the project without issue and I'm testing it as I'm writing.