V2 polish #1179
Merged
V2 polish #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konboi
reviewed
Nov 10, 2025
| except OSError as e: | ||
| # no such file, permission error, etc. | ||
| # report, then continue to next attachment file | ||
| warn_and_exit_if_fail_fast_mode(str(e)) |
| if TEST_SESSION_NAME_RULE.match(value): | ||
| return value | ||
| else: | ||
| raise BadCmdLineException("--name option supports only alphabet(a-z, A-Z), number(0-9), '-', and '_'") |
Contributor
There was a problem hiding this comment.
In version 1, the session name could be used in commands like record build, subset instead of using --session.
However, I remember there was a discussion about separating the options — one for what can be used in the session and another for display purposes.
Therefore, we decided to omit this option at the initial release. Am I wrong??
Contributor
Author
There was a problem hiding this comment.
Got it. That makes sense. I do want to allow users to use arbitrary string for test session display. I'm backing out that half the change now.
Contributor
Author
|
I kept one half of the change and dropped the other. @Konboi please review. |
Konboi
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
record session --session-nameasrecord session --name. Because we got rid of implicit session creation, this option is only available at thesessioncommand, so no need for extrasessionin the option namerecord attachmentshouldn't be an unexpected situation for our CLI. It shouldn't result in a stack trace.