Skip to content

[chore] fix with --no-build option #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Konboi merged 2 commits into from
Jan 15, 2026
Merged

[chore] fix with --no-build option #1220

Konboi merged 2 commits into from
Jan 15, 2026
+24 −4

Conversation

@Konboi
Copy link
Contributor

@Konboi Konboi commented Jan 15, 2026

Even if we set the --no-build option, the --build option is required.

$ smart-tests record session --no-build --test-suite e2e
Missing required option '--build' for command 'session'

However it's a bug. So, fixed it

@Konboi Konboi marked this pull request as ready for review January 15, 2026 00:39
@Konboi Konboi requested review from gayanW and ono-max January 15, 2026 00:43
@Konboi Konboi merged commit 738e47e into main Jan 15, 2026
2 checks passed
@Konboi Konboi deleted the fix-no-build-option branch January 15, 2026 01:51
@github-actions github-actions bot mentioned this pull request Jan 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gayanW gayanW gayanW approved these changes

@ono-max ono-max ono-max approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Konboi @gayanW @ono-max