fix: null values, rounding, and add transaction_count attribute

- actual now defaults to 0 for budgeted categories with no transactions
  this month (unbudgeted categories remain None)
- over_by defaults to 0 when not over budget (was None)
- remaining defaults to 0 when over budget (was None)
- percentage_used rounded to 2 decimal places
- _fetch_monthly_transactions now returns (amounts, counts) tuple
- transaction_count added to enriched category dict and exposed as
  a sensor attribute

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: cloudbr34k84

custom_components/ha_pocketsmith/coordinator.py

@@ -59,7 +59,7 @@ async def _async_update_data(self) -> dict:
             uncategorised_count = await self._fetch_uncategorised_count(session, user_id)
             categories = await self._fetch_categories(session, user_id)
             budget = await self._fetch_budget(session, user_id)
-            monthly_transactions = await self._fetch_monthly_transactions(session, user_id)
+            monthly_transactions, monthly_transaction_counts = await self._fetch_monthly_transactions(session, user_id)
             monthly_events = await self._fetch_monthly_events(session, user_id)
         except aiohttp.ClientError as err:
             raise UpdateFailed(
@@ -70,7 +70,7 @@ async def _async_update_data(self) -> dict:
                 "PocketSmith API request timed out. Check your network connection."
             ) from err
 
-        enriched_categories = self._build_enriched_categories(categories, budget, monthly_transactions, monthly_events)
+        enriched_categories = self._build_enriched_categories(categories, budget, monthly_transactions, monthly_events, monthly_transaction_counts)
 
         return {
             "user_id": user_id,
@@ -80,6 +80,7 @@ async def _async_update_data(self) -> dict:
             "categories": categories,
             "budget": budget,
             "monthly_transactions": monthly_transactions,
+            "monthly_transaction_counts": monthly_transaction_counts,
             "monthly_events": monthly_events,
             "enriched_categories": enriched_categories,
             "forecast_last_updated": dt_util.utcnow(),
@@ -372,8 +373,8 @@ async def _fetch_budget(self, session: aiohttp.ClientSession, user_id: int) -> l
         _LOGGER.debug("Fetched budget for user %s", user_id)
         return budget
 
-    async def _fetch_monthly_transactions(self, session: aiohttp.ClientSession, user_id: int) -> dict:
-        """Return actual spend totals grouped by category ID for the current month."""
+    async def _fetch_monthly_transactions(self, session: aiohttp.ClientSession, user_id: int) -> tuple[dict, dict]:
+        """Return actual spend totals and transaction counts grouped by category ID for the current month."""
         today = date.today()
         start_date = date(today.year, today.month, 1).isoformat()
         last_day = calendar.monthrange(today.year, today.month)[1]
@@ -387,6 +388,7 @@ async def _fetch_monthly_transactions(self, session: aiohttp.ClientSession, user
         base_url = "%s/users/%s/transactions" % (_API_BASE, user_id)
         url = "%s?start_date=%s&end_date=%s&per_page=1000" % (base_url, start_date, end_date)
         totals: dict[int, float] = {}
+        counts: dict[int, int] = {}
         transaction_count = 0
 
         while url:
@@ -447,6 +449,7 @@ async def _fetch_monthly_transactions(self, session: aiohttp.ClientSession, user
                 cat_id = category.get("id")
                 amount = t.get("amount", 0)
                 totals[cat_id] = totals.get(cat_id, 0) + abs(amount)
+                counts[cat_id] = counts.get(cat_id, 0) + 1
                 transaction_count += 1
 
             url = next_url
@@ -455,7 +458,7 @@ async def _fetch_monthly_transactions(self, session: aiohttp.ClientSession, user
             "Fetched %s monthly transactions across %s categories for user %s",
             transaction_count, len(totals), user_id,
         )
-        return totals
+        return totals, counts
 
     async def _fetch_monthly_events(self, session: aiohttp.ClientSession, user_id: int) -> dict:
         """Return budgeted amount totals grouped by category ID for the current month."""
@@ -533,7 +536,7 @@ async def _fetch_monthly_events(self, session: aiohttp.ClientSession, user_id: i
         )
         return totals
 
-    def _build_enriched_categories(self, categories: list, budget: list, monthly_transactions: dict, monthly_events: dict) -> list:
+    def _build_enriched_categories(self, categories: list, budget: list, monthly_transactions: dict, monthly_events: dict, monthly_transaction_counts: dict) -> list:
         """Return a flat enriched list of all categories with monthly budget data.
 
         For each non-transfer category:
@@ -580,6 +583,10 @@ def _flatten(cats, flat):
             # Actual: sourced from monthly transactions
             actual = monthly_transactions.get(cat_id)
 
+            # Default actual to 0 for categories that have budget data
+            if actual is None and cat_id in budget_by_category:
+                actual = 0
+
             # Budgeted: depends on whether this is a bill category
             if cat.get("is_bill"):
                 budgeted = monthly_events.get(cat_id)
@@ -623,9 +630,9 @@ def _flatten(cats, flat):
                 b = budgeted or 0
                 a = actual or 0
                 over_budget = a > b
-                over_by = a - b if over_budget else None
-                remaining = b - a if not over_budget else None
-                percentage_used = (a / b * 100) if b > 0 else None
+                over_by = a - b if over_budget else 0
+                remaining = b - a if not over_budget else 0
+                percentage_used = round(a / b * 100, 2) if b > 0 else None
 
             result.append({
                 "category_id": cat_id,
@@ -641,6 +648,7 @@ def _flatten(cats, flat):
                 "over_budget": over_budget,
                 "percentage_used": percentage_used,
                 "currency": currency,
+                "transaction_count": monthly_transaction_counts.get(cat_id, 0),
             })
 
         return result

custom_components/ha_pocketsmith/manifest.json

@@ -10,5 +10,5 @@
   "iot_class": "cloud_polling",
   "issue_tracker": "https://github.com/cloudbr34k84/home-assistant-pocketsmith/issues",
   "requirements": [],
-  "version": "0.4.3"
+  "version": "0.4.4"
 }

custom_components/ha_pocketsmith/sensor.py

@@ -282,6 +282,7 @@ def extra_state_attributes(self) -> dict:
             "over_budget": e.get("over_budget"),
             "percentage_used": e.get("percentage_used"),
             "currency": e.get("currency"),
+            "transaction_count": e.get("transaction_count"),
         }