Skip to content

[ui-core]: Improve login redirect to capture exact browser URL as next param #4297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
+86 −59
Open

[ui-core]: Improve login redirect to capture exact browser URL as next param #4297

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7b025cb
[ui-core]: Improve login redirect to capture exact browser URL as nex…
ramprasadagarwal Oct 27, 2025
eb38465
[ui-core]: Update backend tests
ramprasadagarwal Oct 31, 2025
12545e3
fixes the backend linting errors
ramprasadagarwal Nov 4, 2025
883c126
Merge branch 'master' of github.com:cloudera/hue into fix/login-issue
ramprasadagarwal Nov 4, 2025
416aaa2
fixes the existing linting in backend
ramprasadagarwal Nov 4, 2025
1d7bd2f
Refactor cx_Oracle import check in desktop tests
ramprasadagarwal Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion desktop/core/src/desktop/middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,11 @@ def process_view(self, request, view_func, view_args, view_kwargs):
)
}) # Remove embeddable so redirect from & to login works. Login page is not embeddable
else:
return HttpResponseRedirect("%s?%s=%s" % (settings.LOGIN_URL, REDIRECT_FIELD_NAME, quote(request.get_full_path())))
# Return a page that redirects using JavaScript to capture the exact browser URL
return render('redirect_to_login.mako', request, {
'login_url': settings.LOGIN_URL,
'redirect_field_name': REDIRECT_FIELD_NAME,
})

def process_response(self, request, response):
if hasattr(request, 'ts') and hasattr(request, 'view_func'):
Expand Down
31 changes: 31 additions & 0 deletions desktop/core/src/desktop/templates/redirect_to_login.mako
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
## Licensed to Cloudera, Inc. under one
## or more contributor license agreements. See the NOTICE file
## distributed with this work for additional information
## regarding copyright ownership. Cloudera, Inc. licenses this file
## to you under the Apache License, Version 2.0 (the
## "License"); you may not use this file except in compliance
## with the License. You may obtain a copy of the License at
##
## http://www.apache.org/licenses/LICENSE-2.0
##
## Unless required by applicable law or agreed to in writing, software
## distributed under the License is distributed on an "AS IS" BASIS,
## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
## See the License for the specific language governing permissions and
## limitations under the License.

<!DOCTYPE html>
<html>
<head>
<title>Redirecting to login...</title>
</head>
<body>
<script>
var browserUrl = window.location.pathname + window.location.search + window.location.hash;
window.location.href = '${login_url}?${redirect_field_name}=' + encodeURIComponent(browserUrl);
Comment on lines +24 to +25
Copy link
Collaborator

@bjornalm bjornalm Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ranade1 What do you think, is it possible somehow to achieve this in middleware.py‎ so that we still can rely on standard browser redirects instead of JS redirect?

</script>
<noscript>
<p>Please <a href="${login_url}">click here to login</a>.</p>
</noscript>
</body>
</html>
Loading