Disable automatic upgrade mode and implement upgrade policies#55
Open
Disable automatic upgrade mode and implement upgrade policies#55
Conversation
Signed-off-by: Roman Schwarz <rs@cloudeteer.de>
Signed-off-by: Roman Schwarz <rs@cloudeteer.de>
Signed-off-by: Roman Schwarz <rs@cloudeteer.de>
Signed-off-by: Roman Schwarz <rs@cloudeteer.de>
Signed-off-by: Roman Schwarz <rs@cloudeteer.de>
2 tasks
Signed-off-by: Roman Schwarz <rs@cloudeteer.de>
Signed-off-by: Roman Schwarz <rs@cloudeteer.de>
Signed-off-by: Roman Schwarz <rs@cloudeteer.de>
591eb51 to
eef08bc
Compare
lixhunter
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes include disabling the automatic upgrade mode and setting a scale-in policy to the oldest VM. Additionally, new variables for upgrade modes and policies have been introduced, along with sorting of VMSS parameters and removal of unnecessary custom data for instance upgrades.
This change prepares the Launchpad for a two-stage upgrade process. Together with upcoming changes in our IaCv3 deployment workflows, this enables safer and more controlled VMSS upgrades.
The VMSS will be configured with
upgrade_mode = "Manual"by default (handled by this PR). This prevents automatic replacement of VMSS instances during configuration changes.VMSS instances will be upgraded manually via
azCLI. This will be handled by our IaCv3 deployment workflows.Example CLI for upgrading outdated VMSS instances:
PR Checklist
breaking-change,feature,fix,other,ignore-releaseMotivation and Context
Closes #19.
Breaking Changes
No breaking changes. Existing deployments must explicitly set
var.upgrade_mode,var.rolling_upgrade_policy, andvar.automatic_os_upgrade_policyto avoid Terraform drift causing a recreation of the VMSS resource.