Conversation
Adding a first draft according to cloudevents#1276 Signed-off-by: Lazzaretti <fabrizio@lazzaretti.me>
|
CI failed with: you should be able to clone an existing he/CN template files and just change the href in there. |
- remove intorudcion - wrap the lines at 80 chars - s/should/will/ - create translation files he/CN Signed-off-by: Lazzaretti <fabrizio@lazzaretti.me>
703ed3f to
d9eae54
Compare
Signed-off-by: Lazzaretti <fabrizio@lazzaretti.me>
d9eae54 to
2e5a250
Compare
|
Overall it looks good with my limited knowledge of AsyncAPI. However, and this might be a nonsensical question, but is there anything more normative we can add? Or are "examples" really all that we can do because each use of it will need to be customized? For example, I kind of expected there to be a "normative" file similar to https://github.com/cloudevents/spec/pull/1349/files#diff-062a9fa03bc40a7d12508a8bfb8780a43aeb9356e395385bc23cb4f810272a1b that says: "here's what the CE stuff would look like, so you should be able to point to (reference?) this in your specific usage", because everything after line 1 should be the same each time, no? Or does that not make sense? |
I agree that a small sample or snippet on how to add it would be helpful. I can add this, but due to the holidays, I will only be able to do so in two weeks. |
|
@Lazzaretti do you still plan on making that change we discussed? Are you back from vacation yet?:-) |
Signed-off-by: Lazzaretti <fabrizio@lazzaretti.me>
@duglin I added two small examples that illustrate how to add the CloudEvents headers or traits to an asyncapi document. Does that address your input? |
|
@Lazzaretti yes that helps! thanks! |
Signed-off-by: Lazzaretti <fabrizio@lazzaretti.me>
|
Approved on the 6/12 call |
Working draft for #1276
Fixes #1276
Clarify how CloudEvents headers can be specified in AsyncAPI.
Proposed Changes
Release Note
Open points
$ref:in cloudevents/working-drafts/asyncapi-examples/light-switch-events-binary-kafka.yaml to trait before merging. The current version is better to test the API spec. Afterwards, it should point to the main branch of the cloudevents/spec repo.