Merged
Conversation
Contributor
Author
|
Can we make the verify test ignore the .github directory? |
Collaborator
|
@jskeet go ahead and rebase on 'main' and it should work now |
Fixes cloudevents#1348 Signed-off-by: Jon Skeet <jonskeet@google.com>
duglin
reviewed
Jun 19, 2025
.github/ISSUE_TEMPLATE/issue.md
Outdated
| - Is this: | ||
| - A feature request for a new form of integration etc? | ||
| - A report of a technical issue with the existing spec? | ||
| - A suggestion for improving the clarity of the existing spec (even if it's not "wrong" as such)? |
Collaborator
There was a problem hiding this comment.
can you wrap things at 80 chars to be consistent with everything else in the repo?
Contributor
Author
There was a problem hiding this comment.
Done in another commit.
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1348