Refactor!: Introduce a Cargo feature for optional Hyper 0 support #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 6, 2024
kornelski
reviewed
Dec 6, 2024
kornelski
approved these changes
Dec 7, 2024
Closes cloudflare#294. Requires breaking changes. The default v0 is changed in favor of v1, but v0 is still kept available, just in a forced module path. It enables dependency de-duplication when consuming it. Signed-off-by: Paul Mabileau <[email protected]>
Contributor
Author
|
Done! Also made it so that exclusive v0 users avoid pulling Tower uselessly by moving features around a bit, which I forgot to do in the previous PR. |
kornelski
approved these changes
Dec 7, 2024
Contributor
Author
|
Works like a charm downstream, many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #294. Requires breaking changes, but only regarding the
hyper1feature's enabled module path; the default v0 is still preserved. What is proposed here in order to achieve the objective is to have both modules be re-exported when the other feature is not enabled, and have them be made public when both features are enabled at the same time. This way, the features should be kept additive: all four combinations are supported. It enables dependency de-duplication when consuming it.