pq patch: enable PQ by default like upstream #400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big diff is misleading. Applying each patch to the base 478b28ab12f and comparing them, we see:
git range-diff 478b28ab12f2001a03261624261fd041f5439706..adcd4022f75953605a9bf9f6a4a45c0b4fd8ed94 478b28ab12f2001a03261624261fd041f5439706..6f1b1e1f451e61cd2bda0922eecaa8387397ac5a 1: adcd4022f ! 1: 6f1b1e1f4 Add additional post-quantum key agreements @@ Commit message This patch adds: - 1. Support for MLKEM768X25519 under the codepoint 0x11ec. The version - of BoringSSL we patch against did not support it yet. + 1. Support for X25519MLKEM768 under the codepoint 0x11ec. The version + of BoringSSL we patch against did not support it yet. Like recent + upstream, enable by default. 2. Supports for P256Kyber768Draft00 under 0xfe32, which we temporarily need for compliance reasons. (Note that this is not the codepoint @@ ssl/extensions.cc: static bool tls1_check_duplicate_extensions(const CBS *cbs) { return true; default: return false; +@@ ssl/extensions.cc: bool ssl_client_hello_get_extension(const SSL_CLIENT_HELLO *client_hello, + } + + static const uint16_t kDefaultGroups[] = { ++ SSL_GROUP_X25519_MLKEM768, + SSL_GROUP_X25519, + SSL_GROUP_SECP256R1, + SSL_GROUP_SECP384R1, ## ssl/ssl_key_share.cc ## @@