Skip to content

Fix types in React example #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kentonv merged 1 commit into from
Oct 30, 2025
Merged

Fix types in React example #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions examples/worker-react/web/src/main/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React, { useMemo, useState } from 'react'
import { useMemo, useState } from 'react'
Copy link
Contributor Author

@third774 third774 Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just removing React import as it shows as unused (and isn't necessary as of React >17)

import { newHttpBatchRpcSession } from '@cloudflare/jsrpc'
import type { Api } from '../../../src/worker'

type Result = {
posts: number
Expand Down Expand Up @@ -55,7 +56,7 @@ export function App() {
const t0 = performance.now()
wrapFetch.setOrigin(t0)
const calls: CallEvent[] = []
const api = newHttpBatchRpcSession('/api')
const api = newHttpBatchRpcSession<Api>('/api')
const userStart = 0; calls.push({ label: 'authenticate', start: userStart, end: NaN })
const user = api.authenticate('cookie-123')
user.then(() => { calls.find(c => c.label==='authenticate')!.end = performance.now() - t0 })
Expand Down Expand Up @@ -83,19 +84,19 @@ export function App() {
const t0 = performance.now()
wrapFetch.setOrigin(t0)
const calls: CallEvent[] = []
const api1 = newHttpBatchRpcSession('/api')
const api1 = newHttpBatchRpcSession<Api>('/api')
const aStart = 0; calls.push({ label: 'authenticate', start: aStart, end: NaN })
const uPromise = api1.authenticate('cookie-123')
uPromise.then(() => { calls.find(c => c.label==='authenticate')!.end = performance.now() - t0 })
const u = await uPromise

const api2 = newHttpBatchRpcSession('/api')
const api2 = newHttpBatchRpcSession<Api>('/api')
const pStart = performance.now() - t0; calls.push({ label: 'getUserProfile', start: pStart, end: NaN })
const pPromise = api2.getUserProfile(u.id)
pPromise.then(() => { calls.find(c => c.label==='getUserProfile')!.end = performance.now() - t0 })
const p = await pPromise

const api3 = newHttpBatchRpcSession('/api')
const api3 = newHttpBatchRpcSession<Api>('/api')
const nStart = performance.now() - t0; calls.push({ label: 'getNotifications', start: nStart, end: NaN })
const nPromise = api3.getNotifications(u.id)
nPromise.then(() => { calls.find(c => c.label==='getNotifications')!.end = performance.now() - t0 })
Expand Down