Fixes for protocol definition #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callArguments is an array of expressions, not an expression that evaluates to an array
Dr-Emann
force-pushed
the
push-pwsnvsymkmzx
branch
from
54fe463 to
6993e69
Compare
Member
|
Sorry for the long delay on reviewing this -- my last month was jam-packed with other stuff and I failed to get to Cap'n Web. Finally getting a chance now. This looks like a good doc update, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the protocol description of array escaping to clarify its recursive nature, and fix the docs around the type of callArguments in a import or pipeline expression.
Fixes #42
Fixes #68
Closes #69