Skip to content

Update single route definition #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update single route definition #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/content/cli-wrangler/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Keys to configure per project in your `wrangler.toml`.
- This is a boolean flag that specifies if your worker will be deployed to your [workers.dev](https://workers.dev) subdomain. If omitted defaults to false.

- `route` <Type>not inherited</Type> <PropMeta>optional</PropMeta>
- A list of routes you’d like to use your worker on. These follow exactly the same rules a `route`, but you can specify a list of them.<br />`routes = ["http://example.com/hello", "http://example.com/goodbye"]` One key of `route`OR `routes` is only if you are not using a [workers.dev](https://workers.dev) subdomain.
- A route, specificied by URL pattern, on your zone that you would like to run your Worker on. <br />`route = "http://example.com/*"`. One key of `route` OR `routes` is only if you are not using a [workers.dev](https://workers.dev) subdomain.
Copy link
Contributor

@kristianfreeman kristianfreeman Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I do wonder if the One key of route or routes is only if... is kinda confusing verbiage but I know it's pre-existing. not a blocker

Copy link

@jclee jclee Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/specificied/specified

Copy link

@jclee jclee Sep 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it feels like there is a word missing from "One key of routeOR routes is only if...", nm, missed that this was already commented on.


- `routes` <Type>not inherited</Type> <PropMeta>optional</PropMeta>
- A list of routes you’d like to use your worker on. These follow exactly the same rules a `route`, but you can specify a list of them.<br />`routes = ["http://example.com/hello", "http://example.com/goodbye"]` One key of `route`OR `routes` is only if you are not using a [workers.dev](https://workers.dev) subdomain.
Expand Down