Remove dark-mode specific shadow height #377
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shadow has an explicit 0.5em height in dark mode, but not in light mode, which falls back to the 0.25em set upstream in the cascade. When the user rapidly changes between dark and light mode, the layout shifts noticeably. Try holding shift+D on [the docs page](https://developers.cloudflare.com/images/cloudflare-images/serve-images) to see it in effect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shadow has an explicit 0.5em height in dark mode, but not in light mode, which falls back to the 0.25em set upstream in the cascade.
If we want to maintain the height in dark mode, we should also set it to be the same in light mode too
When the user rapidly changes between dark and light mode, the layout shifts noticeably. Try holding shift+D on the docs page to see it in effect