Skip to content

Conversation

@kristianfreeman
Copy link
Contributor

@kristianfreeman kristianfreeman commented Oct 12, 2020

This PR improves the workflow process by using the paths-filter workflow to conditionally build jobs only if a path has changed related to that product.

It also adds .github/workflows/build.yml, which runs on each commit to the repo — similar to deploy, it will only run for a product if a change has been found.

Finally, I've bumped the version of https://github.com/actions/checkout to v2 — this doesn't seem to cause any breaking changes and is required for use with paths-filter.

For proof of this working, check out the following commits:

  • 99c252c is a configuration update to the workflows themselves. Because no changes were made inside of products/**, the workflow finishes in 40 seconds and skips every product workflow.
  • 46b6146 is a test commit (removed from this branch history, but still available in the GitHub UI) inside of products/1.1.1.1. In the workflow, the 1.1.1.1 docs are built, while the rest of the products are skipped. This can be confirmed by viewing the Checks page for this commit

@adamschwartz
Copy link
Contributor

Wow this is so cool. Does it work? (Have you tested on a test repo?)

@kristianfreeman kristianfreeman force-pushed the kristian/workflow-improvement-poc branch 8 times, most recently from 088d170 to c650c2f Compare October 12, 2020 17:53
@kristianfreeman kristianfreeman force-pushed the kristian/workflow-improvement-poc branch from 46b6146 to 99c252c Compare October 12, 2020 18:05
@kristianfreeman kristianfreeman marked this pull request as ready for review October 12, 2020 18:06
@kristianfreeman
Copy link
Contributor Author

Wow this is so cool. Does it work? (Have you tested on a test repo?)

yep, it does! I just removed the draft status 👍

@adamschwartz gave me the OK to merge this so I'm going to do that shortly!

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 31, 2025

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e916063
Status: ✅  Deploy successful!
Preview URL: https://11a1adb2.cloudflare-docs-7ou.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants