Skip to content

Conversation

@colbywhite
Copy link
Collaborator

This artifact will be used by later by external processes, i.e. a separate reverse build. This is the first step for removing the reverse build from the build time.

This artifact will be used by later by external processes.
@colbywhite colbywhite marked this pull request as ready for review November 18, 2025 18:14
@github-actions
Copy link
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/.github/ @cloudflare/pcx-content-engineering, @kodster28

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

@colbywhite colbywhite enabled auto-merge (squash) November 18, 2025 19:42
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
ENABLE_LAST_MOD_IN_SITEMAP: true
- uses: actions/upload-artifact@v4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move to after deploy to CF workers just in case there might be errors on this step?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The utopia would be to restructure this workflow to have several jobs (particularly all the various uploads) that run in parallel based on dependencies. For now, I'll add a continue-on-error so it doesn't fail the build regardless of where it happens.

When we remove the reverse build altogether, I'll restructure this workflow to embrace parallelism more.

@colbywhite colbywhite merged commit 97ed380 into production Nov 19, 2025
8 checks passed
@colbywhite colbywhite deleted the pblsh.artfct branch November 19, 2025 15:10
bitcoink188-cpu

This comment was marked as off-topic.

@cloudflare cloudflare deleted a comment from bitcoink188-cpu Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants