Skip to content

Conversation

@ranbel
Copy link
Contributor

@ranbel ranbel commented Sep 6, 2024

PCX-11136

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 6, 2024

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 168e033
Status: ✅  Deploy successful!
Preview URL: https://b0b0fe55.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://ranbel-generic-s2s.cloudflare-docs-7ou.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/cloudflare-one/identity/devices/service-providers/custom/ https://ranbel-generic-s2s.cloudflare-docs-7ou.pages.dev/cloudflare-one/identity/devices/service-providers/custom/
https://developers.cloudflare.com/cloudflare-one/identity/devices/service-providers/workspace-one/ https://ranbel-generic-s2s.cloudflare-docs-7ou.pages.dev/cloudflare-one/identity/devices/service-providers/workspace-one/
https://developers.cloudflare.com/cloudflare-one/identity/devices/service-providers/crowdstrike/ https://ranbel-generic-s2s.cloudflare-docs-7ou.pages.dev/cloudflare-one/identity/devices/service-providers/crowdstrike/
https://developers.cloudflare.com/cloudflare-one/identity/devices/service-providers/kolide/ https://ranbel-generic-s2s.cloudflare-docs-7ou.pages.dev/cloudflare-one/identity/devices/service-providers/kolide/
https://developers.cloudflare.com/cloudflare-one/identity/devices/service-providers/microsoft/ https://ranbel-generic-s2s.cloudflare-docs-7ou.pages.dev/cloudflare-one/identity/devices/service-providers/microsoft/
https://developers.cloudflare.com/cloudflare-one/identity/devices/service-providers/sentinelone/ https://ranbel-generic-s2s.cloudflare-docs-7ou.pages.dev/cloudflare-one/identity/devices/service-providers/sentinelone/
https://developers.cloudflare.com/cloudflare-one/identity/devices/service-providers/taniums2s/ https://ranbel-generic-s2s.cloudflare-docs-7ou.pages.dev/cloudflare-one/identity/devices/service-providers/taniums2s/
https://developers.cloudflare.com/cloudflare-one/identity/devices/service-providers/uptycs/ https://ranbel-generic-s2s.cloudflare-docs-7ou.pages.dev/cloudflare-one/identity/devices/service-providers/uptycs/
https://developers.cloudflare.com/cloudflare-one/identity/devices/service-providers/ https://ranbel-generic-s2s.cloudflare-docs-7ou.pages.dev/cloudflare-one/identity/devices/service-providers/
https://developers.cloudflare.com/cloudflare-one/tutorials/ https://ranbel-generic-s2s.cloudflare-docs-7ou.pages.dev/cloudflare-one/tutorials/

@gitguardian
Copy link

gitguardian bot commented Oct 7, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11021221 Triggered Generic High Entropy Secret dd7c662 astro.config.ts View secret
11021221 Triggered Generic High Entropy Secret dd7c662 astro.config.ts View secret
11021221 Triggered Generic High Entropy Secret dd7c662 astro.config.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@ranbel ranbel marked this pull request as ready for review October 7, 2024 19:20
@ranbel ranbel requested review from a team and kennyj42 as code owners October 7, 2024 19:20
@ranbel ranbel requested a review from kokolocomotion1 October 8, 2024 02:16
@ranbel ranbel requested a review from kokolocomotion1 October 8, 2024 14:32
@bllchmbrs
Copy link
Contributor

@ranbel , Hyperlint dev here. The GitHub API had an intermittent API failure. You can push a nominal change to run the checks again or just ignore them.

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13 files reviewed, 37 total issue(s) found.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • [Pp]arams
  • Kolide
  • Tanium
  • pcx_content_type
  • Uptycs

2. Scroll down to **Device posture providers** and select **Add new**.
3. Select **CrowdStrike**.
4. Enter any name for the provider. This name will be used throughout the dashboard to reference this connection.
<Render file="posture/add-service-provider" params={{ provider: "Crowdstrike" }} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Render file="posture/add-service-provider" params={{ provider: "Crowdstrike" }} />
<Render file="posture/add-service-provider" params={{ provider: "CrowdStrike" }} />

Issues:

  • Style Guide - (Spelling-error) Did you really mean 'Crowdstrike'?

Fix Explanation:

The correct spelling of the company name is 'CrowdStrike', with a capital 'S'. This is a common mistake, but it should be corrected to maintain accuracy and professionalism in the documentation.


import { Render } from "~/components"

Cloudflare Zero Trust allows you to enforce custom device posture checks on your applications. This involves configuring a WARP service-to-service integration that periodially calls the external API of your choice, whether it is a third-party endpoint provider or a home built solution. When called, the API will receive device identifying information from Cloudflare and be expected to return a value between `0` to `100`. You can then set up a device posture check that determines if the returned value counts as a pass or fail; for example, you could allow access to a user only if their device has a posture value greater than `60`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Cloudflare Zero Trust allows you to enforce custom device posture checks on your applications. This involves configuring a WARP service-to-service integration that periodially calls the external API of your choice, whether it is a third-party endpoint provider or a home built solution. When called, the API will receive device identifying information from Cloudflare and be expected to return a value between `0` to `100`. You can then set up a device posture check that determines if the returned value counts as a pass or fail; for example, you could allow access to a user only if their device has a posture value greater than `60`.
Cloudflare Zero Trust allows you to enforce custom device posture checks on your applications. This involves configuring a WARP service-to-service integration that periodically calls the external API of your choice, whether it is a third-party endpoint provider or a home built solution. When called, the API will receive device identifying information from Cloudflare and be expected to return a value between `0` to `100`. You can then set up a device posture check that determines if the returned value counts as a pass or fail; for example, you could allow access to a user only if their device has a posture value greater than `60`.

Issues:

  • Style Guide - (Spelling-error) Did you really mean 'periodially'?

Fix Explanation:

The word 'periodially' is a typo and should be corrected to 'periodically'. This correction aligns with standard spelling and improves the readability and professionalism of the documentation.


<Render file="posture/add-service-provider" params={{ provider: "Custom service provider" }} />
5. In **Access client ID** and **Access client secret**, enter the Access service token used to authenticate to your external API.
6. In **Rest API URL**, enter the external API endpoint that Cloudflare will query for posture information (for example, `https://api.example.com`). For more information, refer to [External API requirements](#external-api-requirements).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
6. In **Rest API URL**, enter the external API endpoint that Cloudflare will query for posture information (for example, `https://api.example.com`). For more information, refer to [External API requirements](#external-api-requirements).
6. In **Rest API URL**, enter the external API endpoint that Cloudflare will query for posture information (for example, `https://API.example.com`). For more information, refer to [External API requirements](#external-api-requirements).

Issues:

  • Style Guide - (Terms-error) Use 'API' instead of 'api'.
  • Style Guide - (Terms-error) Use 'API' instead of 'api'.

Fix Explanation:

The term 'api' should be capitalized to 'API' to comply with the style guide. This is a simple capitalization fix to ensure consistency and professionalism in the documentation.

@bllchmbrs
Copy link
Contributor

Well of course it recovers from that failure right when I post the comment.

@ranbel ranbel merged commit d396e3d into production Oct 8, 2024
12 of 13 checks passed
@ranbel ranbel deleted the ranbel/generic-s2s branch October 8, 2024 19:25
elithrar pushed a commit that referenced this pull request Oct 15, 2024
* create add-service-provider partial

* update UI

* update posture check steps

* add new service provider page

* link to device posture policy info

* update tutorials layout

* create new tutorial placeholder

* access jwt verification

* remove Worker references

* clarify test button

* fix front matter

* fix score

* Update src/content/docs/cloudflare-one/identity/devices/service-providers/custom.mdx

Co-authored-by: marciocloudflare <[email protected]>

* Update src/content/docs/cloudflare-one/identity/devices/service-providers/custom.mdx

Co-authored-by: marciocloudflare <[email protected]>

* Update src/content/docs/cloudflare-one/identity/devices/service-providers/custom.mdx

Co-authored-by: marciocloudflare <[email protected]>

* Update src/content/docs/cloudflare-one/identity/devices/service-providers/custom.mdx

Co-authored-by: marciocloudflare <[email protected]>

* link to Workers example

* update partial frontmatter

---------

Co-authored-by: marciocloudflare <[email protected]>
maheshwarip pushed a commit that referenced this pull request Dec 2, 2024
* create add-service-provider partial

* update UI

* update posture check steps

* add new service provider page

* link to device posture policy info

* update tutorials layout

* create new tutorial placeholder

* access jwt verification

* remove Worker references

* clarify test button

* fix front matter

* fix score

* Update src/content/docs/cloudflare-one/identity/devices/service-providers/custom.mdx

Co-authored-by: marciocloudflare <[email protected]>

* Update src/content/docs/cloudflare-one/identity/devices/service-providers/custom.mdx

Co-authored-by: marciocloudflare <[email protected]>

* Update src/content/docs/cloudflare-one/identity/devices/service-providers/custom.mdx

Co-authored-by: marciocloudflare <[email protected]>

* Update src/content/docs/cloudflare-one/identity/devices/service-providers/custom.mdx

Co-authored-by: marciocloudflare <[email protected]>

* link to Workers example

* update partial frontmatter

---------

Co-authored-by: marciocloudflare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants