Skip to content

Conversation

@helloimalastair
Copy link
Contributor

@helloimalastair helloimalastair commented Sep 27, 2024

Summary

Updated Compatibility Matrix, API Reference, and added Example.

Please merge when feature lands.

Preview

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.

@github-actions github-actions bot added product:r2 R2 object storage: https://developers.cloudflare.com/r2 size/l labels Sep 27, 2024
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 5 total issue(s) found.

Copy link
Collaborator

@dcpena dcpena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small suggestions :) Also, thanks for fixing all of the API content!

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 5 total issue(s) found.


Note: We resolved prior Hyperlint review comments because:

We updated our inline suggestion AI.

We do this to avoid keeping outdated or irrelevant comments around. We'll leave a new review with current comments below.

@dcpena
Copy link
Collaborator

dcpena commented Oct 8, 2024

This content was created before Mikkel's internship ended, but the code hasn't been merged just yet. Leaving open until I get PM go-ahead.

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 3 total issue(s) found.

@helloimalastair
Copy link
Contributor Author

Please hold until runtime update is released

@dcpena
Copy link
Collaborator

dcpena commented Dec 2, 2024

@helloimalastair I added you to the group that gives you merge permissions. You should be able to merge your PR whenever it's ready. 😁

@helloimalastair helloimalastair merged commit fd138e9 into cloudflare:production Dec 5, 2024
6 checks passed
@helloimalastair helloimalastair deleted the sse-c branch December 5, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:r2 R2 object storage: https://developers.cloudflare.com/r2 size/l

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants