Remove reference to setting to fail open or closed. #17200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This setting is no longer present in the dashboard (specifically, when going to the Dashboard -> Workers & Pages -> <project> -> Settings).
aaronj1335
requested review from
a team,
GregBrimble,
WalshyDev,
aninibread and
irvinebroque
as code owners
irvinebroque
assigned
nevikashah and unassigned
irvinebroque,
GregBrimble,
WalshyDev and
aninibread
Contributor
|
Hey @nevikashah - is this one good to merge? |
ToriLindsay
approved these changes
Nov 11, 2024
| The default configuration for all Pages projects is to Fail open. Fail closed can be configured per project by navigating to the Project Settings page. | ||
|
|
||
|
|
||
| ::: |
Contributor
|
I checked the dashboard and confirmed that the setting wasn't there. |
workers-devprod
added
the
contribution
|
Congratulations @aaronj1335, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm3d843mv15570cld0mk9a4n3 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
harshil1712
pushed a commit
that referenced
this pull request
Dec 3, 2024
* Remove reference to setting to fail open or closed. This setting is no longer present in the dashboard (specifically, when going to the Dashboard -> Workers & Pages -> <project> -> Settings). * Update src/content/docs/pages/functions/pricing.mdx * Update src/content/docs/pages/functions/pricing.mdx --------- Co-authored-by: ToriLindsay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This setting is no longer present in the dashboard (specifically, when going to the Dashboard -> Workers & Pages -> -> Settings).
Screenshots (optional)
Documentation checklist
If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.Files which have changed name or location have been allocated redirects.