Workers AI Model Page & Catalog Fixes #17409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hturan
requested review from
a team,
GregBrimble,
KianNH,
WalshyDev,
haleycode,
kristianfreeman,
marciocloudflare,
maxvp and
pedrosousa
as code owners
github-actions
bot
assigned
GregBrimble,
haleycode,
KianNH,
kristianfreeman,
marciocloudflare,
maxvp,
pedrosousa and
WalshyDev
Deploying cloudflare-docs with
|
| Latest commit: |
1d1c4e1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://53b6b6ed.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://hturan-ai-fixes.cloudflare-docs-7ou.pages.dev |
KianNH
approved these changes
Oct 11, 2024
src/components/ModelCatalog.jsx
Outdated
| </div> | ||
| <div className="flex md:w-3/4 w-full gap-[1%] items-stretch self-start flex-wrap !mt-0"> | ||
| {modelList.length === 0 && ( | ||
| <div className="border bg-gray-50 rounded-md w-full flex-col flex align-middle justify-center text-center py-6"> |
Member
There was a problem hiding this comment.
It looks like we're missing dark mode styling for this, but otherwise looks good!
| {node.subpath[node.subpath.length - 1]} | ||
| </code> | ||
| <li | ||
| class={`py-2 !my-0 !list-none ${root ? "" : "border-l border-l-gray-200 pl-4"}`} |
Member
There was a problem hiding this comment.
The colour feels like it might be too light on dark mode, but that's just a nit so happy to leave it as-is.
Contributor
Author
|
Appreciate you @KianNH 🧡 One of these days I'll remember to dev in dark mode too! Just pushed up a couple of fixes for those. |
elithrar
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Implement empty state for model catalog * Clean up model schema design * Dark mode fixes for model empty state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements an empty state for the Workers AI model catalog (when a search or filter returns no results), along with some small design tweaks to the model schema viewers (handling
oneOfstates in a nicer fashion and adding vertical alignments).Screenshots (optional)
Documentation checklist