Skip to content

Conversation

@joshthoward
Copy link
Contributor

Summary

Screenshots (optional)

Documentation checklist

  • The documentation style guide has be
    en adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.
Screenshot 2024-10-08 at 1 46 03 PM Screenshot 2024-10-08 at 1 45 56 PM

@joshthoward joshthoward requested review from a team, elithrar and vy-ton as code owners October 8, 2024 18:46
@github-actions github-actions bot added size/l product:durable-objects Durable Objects: https://developers.cloudflare.com/workers/learning/using-durable-objects/ labels Oct 8, 2024
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, 8 total issue(s) found.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 8, 2024

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7ab17b2
Status: ✅  Deploy successful!
Preview URL: https://fa842f33.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/durable-objects/api/namespace/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/api/namespace/
https://developers.cloudflare.com/durable-objects/reference/data-location/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/reference/data-location/
https://developers.cloudflare.com/durable-objects/api/stub/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/api/stub/
https://developers.cloudflare.com/durable-objects/api/alarms/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/api/alarms/
https://developers.cloudflare.com/durable-objects/api/id/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/api/id/
https://developers.cloudflare.com/durable-objects/api/storage-api/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/api/storage-api/
https://developers.cloudflare.com/durable-objects/api/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/api/
https://developers.cloudflare.com/durable-objects/api/webgpu/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/api/webgpu/
https://developers.cloudflare.com/durable-objects/api/websockets/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/api/websockets/
https://developers.cloudflare.com/durable-objects/api/workers-rs/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/api/workers-rs/

Copy link
Contributor

@vy-ton vy-ton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial feedback focused on DurableObjectNamespace, can do another pass after we finalize format

Oxyjun and others added 5 commits October 9, 2024 09:12
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Copy link
Contributor

@justin-mp justin-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how we have all of our APIs laid out by type then by methods. It makes it much easier to find documentation given a method name.

Oxyjun and others added 3 commits October 9, 2024 15:59
Adding immediately resolvable edits.

Co-authored-by: justin-mp <[email protected]>
@joshthoward joshthoward merged commit f2b55ee into production Oct 9, 2024
13 checks passed
@joshthoward joshthoward deleted the joshthoward/do-docs branch October 9, 2024 17:33
elithrar pushed a commit that referenced this pull request Oct 15, 2024
…17411)

* Add runtime API reference docs for Worker accessible interfaces

* Update data location docs to account for docs for Worker accessible interfaces

* Update src/content/docs/durable-objects/api/namespace.mdx

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>

* Update src/content/docs/durable-objects/api/id.mdx

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>

* Jun/PCX edits part 1

* Replacing relative paths to absolute paths.

* Fixing more invalid relative paths.

* Apply suggestions from code review

Adding immediately resolvable edits.

Co-authored-by: justin-mp <[email protected]>

* Adding suggestion.

* Apply suggestions from code review

* Ensuring consistent wording for description of DurableObjectNamespace.

* Update src/content/docs/durable-objects/api/alarms.mdx

Co-authored-by: justin-mp <[email protected]>

* Update src/content/docs/durable-objects/api/alarms.mdx

Co-authored-by: justin-mp <[email protected]>

* Update src/content/docs/durable-objects/api/storage-api.mdx

Co-authored-by: justin-mp <[email protected]>

* "Two seconds" -> "2 seconds", "six seconds" -> "6 seconds"

* Adding link to best practices section.

* Address remaining comments

---------

Co-authored-by: Jun Lee <[email protected]>
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Co-authored-by: justin-mp <[email protected]>
maheshwarip pushed a commit that referenced this pull request Dec 2, 2024
…17411)

* Add runtime API reference docs for Worker accessible interfaces

* Update data location docs to account for docs for Worker accessible interfaces

* Update src/content/docs/durable-objects/api/namespace.mdx

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>

* Update src/content/docs/durable-objects/api/id.mdx

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>

* Jun/PCX edits part 1

* Replacing relative paths to absolute paths.

* Fixing more invalid relative paths.

* Apply suggestions from code review

Adding immediately resolvable edits.

Co-authored-by: justin-mp <[email protected]>

* Adding suggestion.

* Apply suggestions from code review

* Ensuring consistent wording for description of DurableObjectNamespace.

* Update src/content/docs/durable-objects/api/alarms.mdx

Co-authored-by: justin-mp <[email protected]>

* Update src/content/docs/durable-objects/api/alarms.mdx

Co-authored-by: justin-mp <[email protected]>

* Update src/content/docs/durable-objects/api/storage-api.mdx

Co-authored-by: justin-mp <[email protected]>

* "Two seconds" -> "2 seconds", "six seconds" -> "6 seconds"

* Adding link to best practices section.

* Address remaining comments

---------

Co-authored-by: Jun Lee <[email protected]>
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Co-authored-by: justin-mp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:durable-objects Durable Objects: https://developers.cloudflare.com/workers/learning/using-durable-objects/ size/l

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants