Skip to content

Move reference documentation out of Durable Objects best practices and other fixes #17445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 10, 2024
Merged

Move reference documentation out of Durable Objects best practices and other fixes #17445

merged 6 commits into from
Oct 10, 2024

Conversation

@joshthoward
Copy link
Contributor

@joshthoward joshthoward commented Oct 9, 2024

Summary

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@joshthoward joshthoward requested review from a team, elithrar and vy-ton as code owners October 9, 2024 21:38
@github-actions github-actions bot added the size/l label Oct 9, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

This PR changes current filenames or deletes current files. Make sure you have redirects set up to cover the following paths:

  • /durable-objects/best-practices/access-durable-objects-from-a-worker/

@github-actions github-actions bot added the product:durable-objects Durable Objects: https://developers.cloudflare.com/workers/learning/using-durable-objects/ label Oct 9, 2024
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 9, 2024 •
edited
Loading

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0597b72
Status: ✅  Deploy successful!
Preview URL: https://c2aa592b.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/durable-objects/best-practices/create-durable-object-stubs-and-send-requests/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/best-practices/create-durable-object-stubs-and-send-requests/
https://developers.cloudflare.com/durable-objects/best-practices/error-handling/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/best-practices/error-handling/
https://developers.cloudflare.com/durable-objects/best-practices/access-durable-objects-from-a-worker/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/best-practices/access-durable-objects-from-a-worker/
https://developers.cloudflare.com/durable-objects/get-started/walkthrough/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/get-started/walkthrough/
https://developers.cloudflare.com/durable-objects/api/stub/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/api/stub/
https://developers.cloudflare.com/durable-objects/api/namespace/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/api/namespace/
https://developers.cloudflare.com/durable-objects/api/id/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/api/id/
https://developers.cloudflare.com/durable-objects/reference/websockets/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/reference/websockets/
https://developers.cloudflare.com/durable-objects/get-started/tutorial-with-sql-api/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/get-started/tutorial-with-sql-api/
https://developers.cloudflare.com/queues/examples/use-queues-with-durable-objects/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/queues/examples/use-queues-with-durable-objects/
https://developers.cloudflare.com/durable-objects/observability/troubleshooting/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/durable-objects/observability/troubleshooting/
https://developers.cloudflare.com/workers/configuration/versions-and-deployments/gradual-deployments/ https://joshthoward-do-docs.cloudflare-docs-7ou.pages.dev/workers/configuration/versions-and-deployments/gradual-deployments/

Oxyjun
Oxyjun reviewed Oct 10, 2024
View reviewed changes
@Oxyjun Oxyjun self-assigned this Oct 10, 2024
@Oxyjun
Copy link
Contributor

Oxyjun commented Oct 10, 2024

@joshthoward this PR references links to /durable-objects/best-practices/access-durable-objects-from-a-worker/, but it seems that whole .mdx file was deleted. Was the deletion intentional?

@github-actions github-actions bot added the product:workers Related to Workers product label Oct 10, 2024
@github-actions github-actions bot added the product:queues Cloudflare Queues: https://developers.cloudflare.com/queues label Oct 10, 2024
@joshthoward joshthoward merged commit 6fed1ab into production Oct 10, 2024
13 checks passed
@joshthoward joshthoward deleted the joshthoward/do-docs branch October 10, 2024 16:34
elithrar pushed a commit that referenced this pull request Oct 15, 2024
@joshthoward @Oxyjun @elithrar
Move reference documentation out of Durable Objects best practices an…
d0b1a71 
…d other fixes (#17445)

* Fix multiple parameters sharing bullet in Durable Object Namespace

* Update Durable Objects walkthrough to use RPC

* Add partial for id to string example

* Move reference documentation out of Durable Objects best practices

* Apply suggestions from code review

* fixup! Move reference documentation out of Durable Objects best practices

---------

Co-authored-by: Jun Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Oxyjun Oxyjun Oxyjun approved these changes

@elithrar elithrar Awaiting requested review from elithrar elithrar is a code owner

@vy-ton vy-ton Awaiting requested review from vy-ton vy-ton is a code owner

@GregBrimble GregBrimble Awaiting requested review from GregBrimble GregBrimble is a code owner

@irvinebroque irvinebroque Awaiting requested review from irvinebroque irvinebroque is a code owner

@mikenomitch mikenomitch Awaiting requested review from mikenomitch mikenomitch is a code owner

@WalshyDev WalshyDev Awaiting requested review from WalshyDev WalshyDev is a code owner

@ToriLindsay ToriLindsay Awaiting requested review from ToriLindsay

@toddmantell toddmantell Awaiting requested review from toddmantell

@maheshwarip maheshwarip Awaiting requested review from maheshwarip

Assignees

@elithrar elithrar

@vy-ton vy-ton

@Oxyjun Oxyjun

Labels

product:durable-objects Durable Objects: https://developers.cloudflare.com/workers/learning/using-durable-objects/ product:queues Cloudflare Queues: https://developers.cloudflare.com/queues product:workers Related to Workers product size/l

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joshthoward @Oxyjun @elithrar @vy-ton