-
Notifications
You must be signed in to change notification settings - Fork 10.4k
thomasgauvin: add credential rotation methods to hyperdrive #17464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Oxyjun
merged 10 commits into
production
from
thomasgauvin/update-hyperdrive-to-add-connection-string-rotating
Oct 11, 2024
Merged
thomasgauvin: add credential rotation methods to hyperdrive #17464
Oxyjun
merged 10 commits into
production
from
thomasgauvin/update-hyperdrive-to-add-connection-string-rotating
Oct 11, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 files reviewed, 1 total issue(s) found.
src/content/docs/hyperdrive/configuration/connect-to-private-database copy.mdx
Outdated
Show resolved
Hide resolved
Oxyjun
reviewed
Oct 10, 2024
src/content/docs/hyperdrive/configuration/rotate-credentials.mdx
Outdated
Show resolved
Hide resolved
Oxyjun
reviewed
Oct 10, 2024
src/content/docs/hyperdrive/configuration/rotate-credentials.mdx
Outdated
Show resolved
Hide resolved
Oxyjun
approved these changes
Oct 10, 2024
Deploying cloudflare-docs with
|
| Latest commit: |
b8489fd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0e1954d4.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://thomasgauvin-update-hyperdri.cloudflare-docs-7ou.pages.dev |
Contributor
|
Files with changes (up to 15) |
thomasgauvin
commented
Oct 10, 2024
src/content/docs/hyperdrive/configuration/rotate-credentials.mdx
Outdated
Show resolved
Hide resolved
thomasgauvin
commented
Oct 10, 2024
src/content/docs/hyperdrive/configuration/rotate-credentials.mdx
Outdated
Show resolved
Hide resolved
thomasgauvin
commented
Oct 10, 2024
src/content/docs/hyperdrive/configuration/rotate-credentials.mdx
Outdated
Show resolved
Hide resolved
thomasgauvin
commented
Oct 10, 2024
src/content/docs/hyperdrive/configuration/rotate-credentials.mdx
Outdated
Show resolved
Hide resolved
sejoker
approved these changes
Oct 11, 2024
ReppCodes
reviewed
Oct 11, 2024
Contributor
ReppCodes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
thomasgauvin
commented
Oct 11, 2024
src/content/docs/hyperdrive/configuration/rotate-credentials.mdx
Outdated
Show resolved
Hide resolved
thomasgauvin
commented
Oct 11, 2024
src/content/docs/hyperdrive/configuration/rotate-credentials.mdx
Outdated
Show resolved
Hide resolved
thomasgauvin
commented
Oct 11, 2024
src/content/docs/hyperdrive/configuration/rotate-credentials.mdx
Outdated
Show resolved
Hide resolved
thomasgauvin
commented
Oct 11, 2024
src/content/docs/hyperdrive/configuration/rotate-credentials.mdx
Outdated
Show resolved
Hide resolved
elithrar
pushed a commit
that referenced
this pull request
Oct 15, 2024
* thomasgauvin: add credential rotation methods to hyperdrive * thomasgauvin:rename file and add note to update in situ * Apply suggestions from code review * Update src/content/docs/hyperdrive/configuration/rotate-credentials.mdx * Update src/content/docs/hyperdrive/configuration/rotate-credentials.mdx * Update src/content/docs/hyperdrive/configuration/rotate-credentials.mdx * Update src/content/docs/hyperdrive/configuration/rotate-credentials.mdx * Apply suggestions from code review * Update src/content/docs/hyperdrive/configuration/rotate-credentials.mdx * Update src/content/docs/hyperdrive/configuration/rotate-credentials.mdx --------- Co-authored-by: Jun Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.