replace create-react-app with create-vite in pages how-to/tutorials
#17500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dario-piotrowicz
requested review from
a team,
GregBrimble,
ToriLindsay,
WalshyDev,
aninibread and
irvinebroque
as code owners
github-actions
bot
assigned
aninibread,
GregBrimble,
irvinebroque,
ToriLindsay and
WalshyDev
ToriLindsay
approved these changes
Oct 24, 2024
harshil1712
pushed a commit
that referenced
this pull request
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to/continuation of #17499 (I didn't want to do this in #17499 as I think these are less necessary/potentially controversial, so I figured I'd split it in a separate PR)
create-react-appis not recommended so I am updating their use in the Pages guide withcreate-viteinstead(maybe we could use
create-cloudflarebut in order not too change the guides too significantly I thoughtcreate-vitewould be safer here, this can be revisited later on)Note that that also /pages/tutorials/add-a-react-form-with-formspree uses
create-react-app, but there I did not update the command since the tutorial points to a repository with the source code, which was created viacreate-react-app, so in order to update that tutorial the gh repository should be updated as well (or the link removed), and I am not sure if the tutorial is still relevant and if it is worth investing time updating it.