-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Adding event notifications reference architecture diagram #17639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thomas-desmond
merged 5 commits into
production
from
tdesmond-event-notifications-ref-arch
Oct 22, 2024
Merged
Adding event notifications reference architecture diagram #17639
thomas-desmond
merged 5 commits into
production
from
tdesmond-event-notifications-ref-arch
Oct 22, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 1 total issue(s) found.
src/content/docs/reference-architecture/diagrams/storage/event-notifications-for-storage.mdx
Outdated
Show resolved
Hide resolved
Deploying cloudflare-docs with
|
| Latest commit: |
a3ce300
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8a02e3b5.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://tdesmond-event-notifications.cloudflare-docs-7ou.pages.dev |
Contributor
dcpena
reviewed
Oct 22, 2024
Collaborator
dcpena
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny suggestions to align with style guide. btw, this is great!
src/content/docs/reference-architecture/diagrams/storage/event-notifications-for-storage.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/reference-architecture/diagrams/storage/event-notifications-for-storage.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/reference-architecture/diagrams/storage/event-notifications-for-storage.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/reference-architecture/diagrams/storage/event-notifications-for-storage.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/reference-architecture/diagrams/storage/event-notifications-for-storage.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/reference-architecture/diagrams/storage/event-notifications-for-storage.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/reference-architecture/diagrams/storage/event-notifications-for-storage.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/reference-architecture/diagrams/storage/event-notifications-for-storage.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/reference-architecture/diagrams/storage/event-notifications-for-storage.mdx
Outdated
Show resolved
Hide resolved
dcpena
approved these changes
Oct 22, 2024
harshil1712
pushed a commit
that referenced
this pull request
Dec 3, 2024
* Adding event notifications reference architecture diagram * Add diagram to relevant tutorial * Fix single quote * Update based on feedback * Align with style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
product:r2
R2 object storage: https://developers.cloudflare.com/r2
product:reference-architecture
size/xl
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a new reference architecture diagram page for event notifications with R2 object storage
Documentation checklist