feat: [workflows] clarify when dynamic step names can be used #17993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisDuarte1
requested review from
a team,
celso,
elithrar and
sidharthachatterjee
as code owners
github-actions
bot
added
size/s
product:workflows
sidharthachatterjee
approved these changes
Nov 5, 2024
Contributor
sidharthachatterjee
left a comment
sidharthachatterjee
left a comment
There was a problem hiding this comment.
Thank you, left a suggestion
Co-authored-by: Sidhartha Chatterjee <[email protected]>
elithrar
pushed a commit
that referenced
this pull request
Nov 6, 2024
* feat: [workflows] clarify when dynamic step names can be used * Apply suggestions from code review Co-authored-by: Sidhartha Chatterjee <[email protected]> --------- Co-authored-by: Sidhartha Chatterjee <[email protected]>
harshil1712
pushed a commit
that referenced
this pull request
Dec 3, 2024
* feat: [workflows] clarify when dynamic step names can be used * Apply suggestions from code review Co-authored-by: Sidhartha Chatterjee <[email protected]> --------- Co-authored-by: Sidhartha Chatterjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add more context on when dynamic step names might work. They always do as long they are built in a deterministic manner, this wasn't very explicit before and caused some confusion in users.
Documentation checklist