Skip to content

Conversation

@irvinebroque
Copy link
Contributor

@irvinebroque irvinebroque commented Nov 8, 2024

refs cloudflare/workerd#3083

Do not merge until cloudflare/workerd#3083 has landed in both validator and in Edgeworker

Copy link
Contributor

@danlapid danlapid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@GregBrimble GregBrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting! I thought this would take much longer to land!

@GregBrimble
Copy link
Contributor

You're missing the opt-in date in workerd

@cloudflare-workers-and-pages
Copy link

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 44e9111
Status: ✅  Deploy successful!
Preview URL: https://96295716.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://irvinebroque-patch-3.cloudflare-docs-7ou.pages.dev

View logs

@danlapid
Copy link
Contributor

danlapid commented Nov 8, 2024

You're missing the opt-in date in workerd

I don't think we plan to make this flag default on by compat date just yet.

@GregBrimble
Copy link
Contributor

Oh sorry! Yeah, that's fine then. I misread sort_date here in this PR as the enable date

@irvinebroque irvinebroque merged commit 96e1833 into production Apr 12, 2025
14 checks passed
@irvinebroque irvinebroque deleted the irvinebroque-patch-3 branch April 12, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants