[Docs Site] Adjust feedback prompt on pages with no ToC #18207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KianNH
requested review from
a team,
GregBrimble,
WalshyDev,
haleycode,
kristianfreeman,
marciocloudflare,
maxvp and
pedrosousa
as code owners
github-actions
bot
assigned
GregBrimble,
haleycode,
kristianfreeman,
marciocloudflare and
maxvp
Deploying cloudflare-docs with
|
| Latest commit: |
f8c4890
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bfe4d1f8.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://kian-pcx-14674.cloudflare-docs-7ou.pages.dev |
KimJ15
approved these changes
Nov 15, 2024
GregBrimble
approved these changes
Nov 15, 2024
harshil1712
pushed a commit
that referenced
this pull request
Dec 3, 2024
* [Docs Site] Adjust feedback prompt on pages with no ToC * Hide on homepage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adjust feedback prompt on pages with no ToC.
It should always show at the bottom of the content if there is no ToC, and only when the ToC is hidden due to smaller viewports otherwise.